On Fri, 17 Jul 2026 06:16:56 GMT, Serguei Spitsyn <[email protected]> wrote:
>> This update is for `repo-valhalla` pre-integration. It adds a special intro >> section to the `jvmti.xml` with a general clarification related to value >> objects. Also, it fixes a couple of small typos. >> >> Testing: N/A >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Serguei Spitsyn has updated the pull request incrementally with one > additional commit since the last revision: > > review: update with tweaks suggested by David src/hotspot/share/prims/jvmti.xml line 935: > 933: by the individual functions and events where they apply. > 934: <p/> > 935: In summary, tags for value objects use value equality semantics, and I think this tricky to work as tags are (jlong) values. While more verbose, I wonder if it should be something like "Object tags are `jlong` values that a JVMTI agent can associate with an object. JVMTI allows a value object to be tagged despite the object having no identity. Consequently, the tag is a `jong` value associated with the object's fields rather than its identity.". Having it link to the "Object Tags" section would help too. Alternatively, we could beef up the "Object Tags" section so that this overview/intro section just links without doing into any details except to highlight that value objects can be tagged but ObjectFree events are only sent for tagged identity objects. ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2634#discussion_r3615603280
