On Mon, 20 Jul 2026 15:50:34 GMT, Alan Bateman <[email protected]> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: update with tweaks suggested by David > > src/hotspot/share/prims/jvmti.xml line 935: > >> 933: by the individual functions and events where they apply. >> 934: <p/> >> 935: In summary, tags for value objects use value equality semantics, and > > I think this is tricky to word as tags are (jlong) values. While more > verbose, I wonder if it should be something like "Object tags are `jlong` > values that a JVMTI agent can associate with an object. JVMTI allows a value > object to be tagged despite the object having no identity. Consequently, the > tag is a `jong` value associated with the object's fields rather than its > identity.". Having it link to the "Object Tags" section would help too. > Alternatively, we could beef up the "Object Tags" section so that this > overview/intro section just links without doing into any details except to > highlight that value objects can be tagged but ObjectFree events are only > sent for tagged identity objects. @AlanBateman There was a request to finalize the SVC CSR now. So, I'll integrate this now as is, and we can incorporate your suggestion later, ------------- PR Review Comment: https://git.openjdk.org/valhalla/pull/2634#discussion_r3617590460
