Federico Simoncelli has posted comments on this change.

Change subject: BZ#741203 Use cached node id if SPM is active
......................................................................


Patch Set 1:

At the moment this is the best fix we can have. It's reverting the behavior to 
vdsm96 and it's not breaking the fix for BZ#733909. Adding an additional option 
"useCache" (to force reading from cache) to each call used in 
getStoragePoolInfo is going to affect several APIs:

sd.StorageDomain.getMetaParam()
sd.StorageDomain.getPools()
sd.StorageDomain.getVersion()
sp.StoragePool.getMetaParam()
sp.StoragePool.getDomains()
sp.StoragePool.getDescription()
sp.StoragePool.getMasterVersion()

My impression is that this is not a good idea for the design.

--
To view, visit http://gerrit.usersys.redhat.com/1004
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee15c4b35a415e9ea460b1ce6a4afa14d147ed8d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to