Dan Kenigsberg has posted comments on this change. Change subject: BZ#741203 Use cached node id if SPM is active ......................................................................
Patch Set 1: (2 inline comments) .................................................... File vdsm/storage/hsm.py Line 1175: vars.task.getSharedLock(STORAGE, spUUID) Line 1176: Line 1177: info = self.getPool(spUUID).getInfo() Line 1178: Line 1179: # If we claim to be the SPM we have to be really sure we are I don't think I can judge between you two, but the comment should not have been copied here. The code below handles the non-spm case. Line 1180: if self.spm.spmRole == spm.SPM_FREE: Line 1181: info['spm_id'] = self.getPool(spUUID).getSpmId() Line 1182: Line 1183: return info Line 1177: info = self.getPool(spUUID).getInfo() Line 1178: Line 1179: # If we claim to be the SPM we have to be really sure we are Line 1180: if self.spm.spmRole == spm.SPM_FREE: Line 1181: info['spm_id'] = self.getPool(spUUID).getSpmId() this is going to invalidate our cache every few seconds, isn't it bad? Line 1182: Line 1183: return info Line 1184: Line 1185: -- To view, visit http://gerrit.usersys.redhat.com/1004 To unsubscribe, visit http://gerrit.usersys.redhat.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee15c4b35a415e9ea460b1ce6a4afa14d147ed8d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
