Federico Simoncelli has posted comments on this change.
Change subject: BZ#741203 Use cached node id if SPM is active
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File vdsm/storage/spm.py
Line 526:
Line 527: # Restore tasks is last because tasks are spm ops
(spm has to be started)
Line 528: self.taskMng.recoverDumpedTasks()
Line 529:
Line 530: pool.isSPM = True
Can you check if this is compatible with line 560? Looks like the order there
can't be inverted:
pool = hsm.HSM.getPool(spUUID) and then use pool.spmStarted
Line 531: self.log.debug("ended.")
Line 532:
Line 533: except Exception, e:
Line 534: self.log.error("Unexpected error", exc_info=True)
....................................................
File vdsm/storage/sp.py
Line 1294: 'masterValidate' : { 'mount' : False, 'valid' :
False }
Line 1295: }
Line 1296: code = 0
Line 1297: try:
Line 1298: if not self.isSPM:
I'll pass a new option useCache=self.isSPM which will avoid the cache
invalidation. Is that ok?
Line 1299: domain.selftest()
Line 1300:
Line 1301: res = domain.getStats()
Line 1302: stats.update(res)
--
To view, visit http://gerrit.usersys.redhat.com/1004
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee15c4b35a415e9ea460b1ce6a4afa14d147ed8d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
