Dan Kenigsberg has posted comments on this change.
Change subject: BZ#743549 - Allow concurrency in task manager
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
nacking my own code is fun.
....................................................
File vdsm/storage/taskManager.py
Line 101: """ Return Task status for all tasks by type.
Line 102: """
Line 103: self.log.debug("Entry.")
Line 104: subRes = {}
Line 105: for taskID, task in self._tasks.iteritems():
Isn't it my own code? I abandoned it for a reason - iteritems() explodes if you
concurrently delete an element from self._tasks. Use items() instead - or
deepcopy ;-)
Line 106: if not tag or tag in task.getTags():
Line 107: subRes[taskID] = self.getTaskStatus(taskID)
Line 108: self.log.debug("Return: %s", subRes)
Line 109: return subRes
--
To view, visit http://gerrit.usersys.redhat.com/997
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b04a8b22ac40e39e89bbbee56309c015586fc1f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Rami Vaknin <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
