Dan Kenigsberg has posted comments on this change.
Change subject: BZ#743549 - Allow concurrency in task manager
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/taskManager.py
Line 103: self.log.debug("Entry.")
Line 104: subRes = {}
Line 105: for taskID, task in self._tasks.items():
Line 106: if not tag or tag in task.getTags():
Line 107: subRes[taskID] = self.getTaskStatus(taskID)
those horrible "produces".
self.getTaskStatus --> task.deprecated_status()
Line 108: self.log.debug("Return: %s", subRes)
Line 109: return subRes
Line 110:
Line 111:
Line 179: self.log.debug("Entry.")
Line 180: subRes = {}
Line 181: for taskID, task in self._tasks.items():
Line 182: if not tag or tag in task.getTags():
Line 183: subRes[taskID] = self.getTaskInfo(taskID)
self.getTaskInfo --> task.getInfo()
Line 184: self.log.debug("Return. Response: %s", subRes)
Line 185: return subRes
Line 186:
Line 187:
--
To view, visit http://gerrit.usersys.redhat.com/997
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b04a8b22ac40e39e89bbbee56309c015586fc1f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Rami Vaknin <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
