Dan Kenigsberg has posted comments on this change.
Change subject: BZ#743549 - Allow concurrency in task manager
......................................................................
Patch Set 5: Looks good to me, approved
(1 inline comment)
....................................................
File vdsm/storage/taskManager.py
Line 104: subRes = {}
Line 105: for taskID, task in self._tasks.items():
Line 106: if not tag or tag in task.getTags():
Line 107: try:
Line 108: subRes[taskID] = self.getTaskStatus(taskID)
I find this solution cumbersome, as it does not solve the supposed problem of
reporting already stopped tasks - it only makes it slightly smaller.
however, since it solves the main issue, of blowing up if a task is stopped
while in this function, let's take it.
Line 109: except se.UnknownTask:
Line 110: # Return statuses for existing tasks only.
Line 111: self.log.warn("Unknown task %s. Maybe task was
already cleared.", taskID)
Line 112: self.log.debug("Return: %s", subRes)
--
To view, visit http://gerrit.usersys.redhat.com/997
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b04a8b22ac40e39e89bbbee56309c015586fc1f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Rami Vaknin <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
