Federico Simoncelli has posted comments on this change.

Change subject: Do not attempt to configure the iscsid service
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File vdsm/storage/iscsi.py
Line 146:     (mRet, mOut, mErr) = misc.execCmd(ISCSIADM_NODE + args + 
MANUAL_STARTUP)
Not to all targets, just to all the targets discovered using the portal 
specified in the previous call. I'd rather not change the startup configuration 
for the portals managed directly by the sysadmin. This means that the sysadmin 
is still able to manually add automatic iscsi targets if he wants to.

--
To view, visit http://gerrit.ovirt.org/305
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2dc0cc114fcc660d8b6b35e6654dfb2592eeb000
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to