Ayal Baron has posted comments on this change. Change subject: Do not attempt to configure the iscsid service ......................................................................
Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) I love patches that remove more lines than they add, but functionally support more than before :) .................................................... File vdsm/storage/iscsi.py Line 153: if dRet != 0: why not check this immediately after the call to discover? -- To view, visit http://gerrit.ovirt.org/305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2dc0cc114fcc660d8b6b35e6654dfb2592eeb000 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
