Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: new verb: migration cancel
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(3 inline comments)
....................................................
Commit Message
Line 10: if there is no migration in progress it will return error.
please mention what would migrateStatus return after migration has been
canceled.
....................................................
File vdsm/define.py
Line 32: 'migCancelErr': {'status': {'code':12, 'message':
'Migration not in progress'}},
using the same errorcode twice is impolite
....................................................
File vdsm/vm.py
Line 890: return errCode['migCancelErr']
error content is swallowed here. you may simply re-raise the exception.
--
To view, visit http://gerrit.ovirt.org/480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f503c444c4ca1469c18480d6ca29fba8f011d4c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
