Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: new verb: migration cancel
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
very minor comments, generally looking good.
....................................................
File vdsm/vm.py
Line 229: # yes ugly searching in the error message,
Putting a TODO marker here may be helpful
Line 233: e.get_error_message().find('canceled by
client') > 0:
I find
'canceled by client' in e.get_error_message()
more elegant. and you?
P.S I would very much prefer new code with lines shorter than 80 chars. It is
easier for me to review.
--
To view, visit http://gerrit.ovirt.org/480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f503c444c4ca1469c18480d6ca29fba8f011d4c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
