Igor Lvovsky has posted comments on this change.
Change subject: vdsm: new verb: migration cancel
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Should we change VM statuses from 'Migration Source' to prior value after
migration cancellation?
....................................................
File vdsm/define.py
Line 45: 'migCancelErr': {'status': {'code':45, 'message':
'Migration not in progress'}},
I am already using error codes 45,46 for hotplug.
I know that first merged patch should win, but because hotplug patch already in
gerrit and to avoid unnecessary rebases in the feature please consider to
change error code to 47
--
To view, visit http://gerrit.ovirt.org/480
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f503c444c4ca1469c18480d6ca29fba8f011d4c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
