Adam Litke has posted comments on this change. Change subject: API: Separate clientIF and the xmlrpc server ......................................................................
Patch Set 1: (3 inline comments) .................................................... File vdsm/clientIF.py Line 131: file(constants.P_VDSM_CLIENT_LOG, 'w') Hmm, I don't quite understand. How would touching a local log file serve to verify whether a network connection has been severed? Assuming this remains the best way to accomplish this check, would it be acceptable to just move the log file touch into the editNetwork verb itself? Line 173: Done Line 290: # stop listening ASAP Done -- To view, visit http://gerrit.ovirt.org/620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5026e11f3d39343c957b59606e90c23acbb598ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
