Saggi Mizrahi has posted comments on this change.
Change subject: API: Separate clientIF and the xmlrpc server
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(4 inline comments)
Looks good, only minor comments.
....................................................
File vdsm/clientIF.py
Line 62: class bindingXMLRPC:
Classes should start with a capital letter.
Please make it a new style class
Line 66: self.serverPort = config.get('addresses', 'management_port')
Classes other then HSM\ClientIF should not access the configuration unless
unavoidable. Please access the config in client IF and then pass it to the ctor
of this calls.
Avoiding touching the config makes unit testing stub creation and a bunch of
other stuff easier.
Line 77: self.server.timeout = 1
This looks like something that might need to be configurable but I'm not sure
about that.
Line 343: def getGlobalMethods(self):
You can inspect the hsm object for exported methods.
Look at dispatcher.py on how to do that.
--
To view, visit http://gerrit.ovirt.org/620
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5026e11f3d39343c957b59606e90c23acbb598ba
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
