Dan Kenigsberg has posted comments on this change. Change subject: API: Separate clientIF and the xmlrpc server ......................................................................
Patch Set 1: (2 inline comments) .................................................... File vdsm/clientIF.py Line 131: file(constants.P_VDSM_CLIENT_LOG, 'w') editNetwork changes host network configuration and waits. If ANOTHER api call (ping, getVdsCaps, whatever) arrives, we know that we have a working network config, and commit it. We use a file, instead of an in-process event, since editNetork is executed in another process, as root. It would have been WAY more nicer to `touch` P_VDSM_CLIENT_LOG in an API wrapper (but to make sure it is not called if vdsm calls its own api from an async task). We could add a FIXME about it in this patch (to keep up with is advertisement), and solve it somehow in a later patch. Line 373: ] ]->) as this is not expected to change during runtime ;-) -- To view, visit http://gerrit.ovirt.org/620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5026e11f3d39343c957b59606e90c23acbb598ba Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
