Igor Lvovsky has posted comments on this change. Change subject: Avoid to activate parent volume on cloning ......................................................................
Patch Set 2: I would prefer that you didn't submit this (4 inline comments) .................................................... File vdsm/storage/sp.py Line 1879: # Acquiring the lock on the image only if it's not a snapshot It's not very clear. Do you mean 'Acquiring the lock on the image only if created volume not a snapshot' ? Line 1880: if (imgUUID != srcImgUUID) or (volFormat != volume.COW_FORMAT): why (imgUUID != srcImgUUID) ? Actually it's OK to get srcImgUUID as zero-UUID for snapshot, it's mean 'Create snapshot on the same iamge'. If you want to do this you need to check (volUUID != srcVolUUID). Line 1899: return dict(uuid=uuid) Gennerally, I am not really happy with this change. If you decided create snapshots without locking, why you need locking at all? Only for base volumes ? Anyway, why this related to 'clone volume' patch? .................................................... File vdsm/storage/volume.py Line 876: size = int(size) Do you aware that sometimes we pass 'size' parameter in sectors? Did you checked that in all appearances of volume.createVolume() you have right 'size' ? -- To view, visit http://gerrit.ovirt.org/570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a7d488da5ab0c27fc2e083976d4bc44e6f810e3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
