Federico Simoncelli has posted comments on this change. Change subject: Avoid to activate parent volume on cloning ......................................................................
Patch Set 2: (2 inline comments) .................................................... File vdsm/storage/sp.py Line 1879: # Acquiring the lock on the image only if it's not a snapshot This all is removed in the newer version. .................................................... File vdsm/storage/volume.py Line 876: size = int(size) I am aware of that but "sometimes" is not much descriptive. Are you suggesting that somewhere we call createVolume using sectors and we never noticed it because we didn't hit the "else" section? I didn't find any trace of that, the value used here comes from the manager so I can't guarantee that they'll be always using the same unit (even if they should). -- To view, visit http://gerrit.ovirt.org/570 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a7d488da5ab0c27fc2e083976d4bc44e6f810e3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
