Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
/rhev/ appears elsewhere, too:
vdsm/config.py.in: ('repository', '/rhev/data-center',
vdsm/vdsm-sosplugin.py.in: self.collectExtOutput("/bin/su vdsm -s
/bin/sh -c '/usr/bin/tree /rhev/data-center/'")
vdsm/vdsm-sosplugin.py.in: self.collectExtOutput("/bin/su vdsm -s
/bin/sh -c '/bin/ls -lR /rhev/'")
vdsm/vdsmd.8:.FN /rhev/data-center/
vdsm_cli/dumpStorageTable.py:DC = '/rhev/data-center/'
(and implicitly in getDomUuidFromMetafilePath,getDomUuidFromVolumePath )
Let's do this correctly!
....................................................
File configure.ac
Line 54: AC_SUBST([vdsmrepo], ['rhev'])
could you put the complete /rhev/data-center here?
....................................................
File vdsm.spec.in
Line 423: %dir %attr(0775, root, root) /@vdsmrepo@
I have a deja-vu all over again.
why not do it in RHEL, too?
--
To view, visit http://gerrit.ovirt.org/548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I971a7b47e834d7b6b95874ff6437e66b1928fc82
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
