Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
......................................................................


Patch Set 3: (2 inline comments)

I will provide a new patch to use autoconf for all places that touch in rhev 
dir.

Thanks
Douglas

....................................................
File configure.ac
Line 54: AC_SUBST([vdsmrepo], ['rhev'])
We have others 3 places which use simple 'rhev', like:

vdsm.spec.in:
mkdir %{buildroot}/@vdsmrepo@
%dir %attr(0775, root, root) /@vdsmrepo@

vdsm.rwtab:
empty    /rhev

So, that's why I used 'rhev' only.

....................................................
File vdsm.spec.in
Line 423: %dir %attr(0775, root, root) /@vdsmrepo@
Yep, it's a bad deja-vu. Next patch will fix that.

--
To view, visit http://gerrit.ovirt.org/548
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I971a7b47e834d7b6b95874ff6437e66b1928fc82
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to