Dan Kenigsberg has posted comments on this change.
Change subject: vdsm.spec.in/vdsm.rwtab: create /rhev repository
......................................................................
Patch Set 4: Fails; I would prefer that you didn't submit this
(2 inline comments)
make rpm fails to me (I did not research why)
sed -e "s,[@]CONFDIR[@],/etc/vdsm,g" -e
"s,[@]VDSMLOGDIR[@],/var/log/vdsm,g" -e "s,[@]VDSMDIR[@],/usr/share/vdsm,g" -e
"s,[@]HOOKSDIR[@],/usr/libexec/vdsm/hooks,g" -e
"s,[@]VDSMRUNDIR[@],/var/run/vdsm,g" -e "s,[@]VDSMLIBDIR[@],/var/lib/vdsm,g" -e
"s,[@]POOLSDIR[@],/var/run/vdsm/pools,g" -e
"s,[@]BACKUPDIR[@],/var/log/vdsm/backup,g" -e
"s,[@]LIBEXECDIR[@],/usr/libexec/vdsm,g" -e "s,[@]VDSMREPO[@],/rhev,g" -e
"s,[@]TRUSTSTORE[@],/etc/pki/vdsm,g" < ./vdsmd.8.in > vdsmd.8; \
fi
/bin/sh: line 3: ./vdsmd.8.in: No such file or directory
....................................................
File vdsm/storage/fileSD.py.in
Line 46: return metafile.split('/')[5]
I don't think it makes sense to change this by autoconf.
What you need here is only to count the number of path elements in config's
repository (to avoid the issue noticed by Igor). This counting may well be done
during runtime.
....................................................
File vdsm/storage/fileVolume.py.in
Line 37: return volPath.split('/')[4]
see fileSD comment
--
To view, visit http://gerrit.ovirt.org/548
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I971a7b47e834d7b6b95874ff6437e66b1928fc82
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
