Dan Kenigsberg has posted comments on this change. Change subject: Make getRoutes() return the default gateway of an interface, otherwise the gateway of an interface last occurs in /proc/net/route would be the result when multiple gateways are assigned to the interface, which is clearly not we want. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) .................................................... Commit Message Line 7: Make getRoutes() return the default gateway of an interface, git commit messages shouls start with a short subject line, empty line, and then a long story. Please excuse me, I do not understand which was the routing table that broke this function. Could you provide an example? -- To view, visit http://gerrit.ovirt.org/1101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bceb3be2495bc80931c709e2132ff4542e6b763 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Hunt Xu <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
