Douglas Schilling Landgraf has posted comments on this change.

Change subject: Make getRoutes() return the default gateway of each bridge 
interface
......................................................................


Patch Set 2: Verified; Looks good to me, but someone else must approve

Reproduced the report and the fix is correct.

Listing the currenct routes:
# route -n
Destination     Gateway
0.0.0.0         192.168.1.1
<snip>
192.168.1.0     0.0.0.0 

Adding a new route:
# route add -net 192.168.123.0/24 gw 192.168.1.101 dev ovirtmgmt

Listing routes:
# route -n
Destination     Gateway
0.0.0.0         192.168.1.1
<snip>
192.168.1.0     0.0.0.0 
192.168.123.0   192.168.1.101 
^ new route added

# python ./code-from-vdsm.py 
{'ovirtmgmt': '192.168.1.101'}
Got the last gateway added

Now executing with the changes:
# python ./code-from-vdsm.py 
{'ovirtmgmt': '192.168.1.1'}
Got the ovirtmgmt gateway

--
To view, visit http://gerrit.ovirt.org/1101
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6bceb3be2495bc80931c709e2132ff4542e6b763
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Hunt Xu <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to