Hunt Xu has posted comments on this change.
Change subject: Make getRoutes() return the default gateway of an interface,
otherwise the gateway of an interface last occurs in /proc/net/route would be
the result when multiple gateways are assigned to the interface, which is
clearly not we want.
......................................................................
Patch Set 1: No score
(1 inline comment)
....................................................
Commit Message
Line 7: Make getRoutes() return the default gateway of an interface,
Assuming "route -n" gives the following result:
Kernel IP routing table
Destination Gateway Genmask Flags Metric Ref Use Iface
0.0.0.0 192.168.1.1 0.0.0.0 UG 303 0 0 engine
192.168.1.0 0.0.0.0 255.255.255.0 U 303 0 0 engine
Calling this function would get {'engine': '192.168.1.1'}, which is ok.
After adding a route to another subnet using "route add -net 192.168.10.0/24
x.x.x.x dev engine", again calling the function we would now get {'engine':
'x.x.x.x'}.
So isn't the former result we are always expecting? Or whatever route of an
interface returned would be accepted?
--
To view, visit http://gerrit.ovirt.org/1101
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bceb3be2495bc80931c709e2132ff4542e6b763
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Hunt Xu <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Hunt Xu <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
