Federico Simoncelli has posted comments on this change.
Change subject: added mtu support for network interface
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File vdsm/configNetwork.py
Line 332: if line.startswith(entry + '=') ]
You may want to consider to:
- use strip() to remove any white character from the beginning/end of the line
- use split("=", 1) to split key/values (so you can avoid the
startswith/[len(entry)+1:])
- use "with open(conffile)" to read the file
(Use the same suggestions for _updateConfigValue)
Line 548: gateway=gateway, **options)
Looks like addBridge/addVlan/addBonding/addNic are low level enough to assume
that "mtu" value is correct. Therefore I would:
- get rid of all the "int(mtu)" in addBridge/addVlan/addBonding/addNic
- validate the mtu value only at the beginning of addNetwork (returning a
descriptive error when needed)
--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
