Dan Kenigsberg has posted comments on this change.
Change subject: added mtu support for network interface
......................................................................
Patch Set 8: (2 inline comments)
sorry man, serious stuff this time.
....................................................
File vdsm/BindingXMLRPC.py
Line 314: def addNetwork(self, bridge, vlan=None, bond=None, nics=None,
mtu=None, options={}):
sorry for considering this only now, but this would break backward
compatibility - old Engines would send "options" in this position. we have no
choice but to throw mtu into the existing options dictionary.
Line 316: return api.addNetwork(bridge, vlan, bond, nics, mtu,
options={})
I'd do the same here (even there's no bc problems yet)
--
To view, visit http://gerrit.ovirt.org/754
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
