Dan Kenigsberg has posted comments on this change. Change subject: added mtu support for network interface ......................................................................
Patch Set 7: I would prefer that you didn't submit this (2 inline comments) two minor comments. .................................................... File vdsm/configNetwork.py Line 369: ''' method checks to see if the current bridge has MTU docstring text should look like """Update MTU for devices that are to remain after "bridge" is removed method checks to see if the current bridge has MTU .... etcetc Line 561: configWriter.addBonding(bonding, ifaceBridge, bondingOptions=bondingOptions, mtu=mtu) you should not reduce bonding mtu, too! -- To view, visit http://gerrit.ovirt.org/754 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d8f38627dd1a59830e426484228c1796081ad1b Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Peter V. Saveliev <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
