Douglas Schilling Landgraf has posted comments on this change.

Change subject: contrib: Adding contrib/nfs-check.py
......................................................................


Patch Set 4: (12 inline comments)

....................................................
File contrib/nfs-check.py
Line 28:     print "Usage: " +  sys.argv[0] + " server:/target"
Done

Line 36:     def handler(self,signum, frame):
Done

Line 41:         process = subprocess.Popen(['mount', "-t", "nfs", cmd, 
pathName],
Done

Line 53:             print "Timeout, cannot mount the nfs! Please check the 
status" \
If the nfs server is not available or the address of the nfs server is wrong, 
the mount will keep trying to mount it... So, to avoid the 'lock stage' I have 
added a timeout.

Line 62:                if not os.path.isfile("/etc/exports"):
Done

Line 66:                strFound = False
Done

Line 67:                with open('/etc/exports', 'r') as f:
Done

Line 78:                    print "The local path %s doesn't exist."
Done

Line 107:             process = subprocess.Popen(['sudo', "-u", "vdsm", 
"touch", fileTest],
Done

Line 122:             if ret != 0:
Done

Line 160:             print "cannot execute umount()!"
Done

Line 199:     os.removedirs(LOCALPATH)
Done

--
To view, visit http://gerrit.ovirt.org/916
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d3231077fb59e11be1d61a578a96a3988559ff3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to