Dan Kenigsberg has posted comments on this change. Change subject: contrib: Adding contrib/nfs-check.py ......................................................................
Patch Set 7: I would prefer that you didn't submit this (2 inline comments) .................................................... File contrib/nfs-check.py Line 71: print "Timeout, cannot mount the nfs! Please check the status " \ I did not receive an answer - have you tested this flow (sigalarm while communicate()). Line 212: output = process.communicate()[1].strip() you are taking the second element of communicate() (which is the stderr) and call it output. I still do not understand if this is intentional. -- To view, visit http://gerrit.ovirt.org/916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d3231077fb59e11be1d61a578a96a3988559ff3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
