Douglas Schilling Landgraf has posted comments on this change. Change subject: contrib: Adding contrib/nfs-check.py ......................................................................
Patch Set 5: (4 inline comments) .................................................... File contrib/nfs-check.py Line 46: self.nfsServer = None Done Line 84: if ret != 0 and localMachine == True: Done Line 180: print output Done Line 197: output = process.communicate()[1].strip() Indeed, in this case, I am looking only for error output but popen.communicate returns a tuple of stdout stderr that's why I used output. If you prefer, I can change it to errput. -- To view, visit http://gerrit.ovirt.org/916 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d3231077fb59e11be1d61a578a96a3988559ff3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
