Saggi Mizrahi has posted comments on this change.
Change subject: ISCSI Subsystem refactoring
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 1978: "target": {
This entire API call was invented 2 patches ago by me. No one ever used it as
it never got into working VDSM code.
Line 2027: # TODO: Handle possible CID collision
The refactoring has nothing to do with that. CID collisions are a monitor
issue. In any case I'm moving stuff some more in next patches CID collisions
will not be a problem in the future,
....................................................
File vdsm/storage/iscsiadm.py
Line 50: #FIXME: can be optimized by checking /var/lib/iscsi/ifaces
It can be further optimized here
....................................................
File vdsm/storage/iscsi.py
Line 2: # Copyright 2009-2011 Red Hat, Inc.
Graaaa
The only line I didn't change in this file!!
The only line
--
To view, visit http://gerrit.ovirt.org/1607
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
