Federico Simoncelli has posted comments on this change. Change subject: ISCSI Subsystem refactoring ......................................................................
Patch Set 4: I would prefer that you didn't submit this (4 inline comments) Reviewing the changes in iscsi.py is a quite long task, I saw few minor things to change there but they all looks inherited from the old code and in general are good enough. Marking with -1 for few typos and a change in constants.py that you can't deny :-). .................................................... Commit Message Line 9: !!Do not apply with out following patch!! Without Line 17: * tpgt now refres to tpgt Refers (twice) Line 19: * actually Bullets and new-line inconsistency .................................................... File vdsm/constants.py.in Line 149: STRG_MPATH_CONF = """ Ah what a lost opportunity here!!! All these constants are used only in the modules you are refactoring, why didn't you move them there? It would be a step forward to remove your hated constants.py. -- To view, visit http://gerrit.ovirt.org/1607 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
