Federico Simoncelli has posted comments on this change.
Change subject: ISCSI Subsystem refactoring
......................................................................
Patch Set 5: (4 inline comments)
....................................................
File vdsm/storage/hsm.py
Line 2294: if username or password:
We probably don't need to check twice the username and the password (see line
2288):
if username:
cred = iscsi.ChapCredentials(username, password)
else:
cred = None
Line 2303: fullTargets.append("%s:%d,%d %s" % (target.portal.host,
target.portal.port, target.tpgt, target.iqn))
If you need to revise this file, could you keep this line in 80 chars?
....................................................
File vdsm/storage/iscsiadm.py
Line 10: class IscsiError(RuntimeError): pass
Is it possible to squash here the changes from http://gerrit.ovirt.org/1038 ?
(Refactor storage connection subsystem)
....................................................
File vdsm/storage/Makefile.am
Line 39: iscsiadm.py \
Tab inconsistency
--
To view, visit http://gerrit.ovirt.org/1607
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
