Saggi Mizrahi has posted comments on this change.
Change subject: added support for mirror promisc mode
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/tc.py
Line 23: class MirrorPromisc():
You misunderstood.
You need tc.py which is a thin wrapper around the tc tool
tc.py
--------
def qdisc_add(networkname):
command = [EXT_TC, 'qdisc', 'add', 'dev', networkName,
'ingress']
retcode, out, err = storage.misc.execCmd(command, raw=True,
sudo=False)
if retcode != 0:
e = errmsg % (list2cmdline(command), err)
raise Exception(e)
def qdisc_replace(networkName, parent='root'):
.....
I think you got the point
---------------
Now that you have a thin wrapper around tc in tc.py
create a method called set\unsetPromisc(nics) somewhere else (not in the thin
wrapper as this uses more then 1 thinly wrapped calls
Have them accessible through supervdsm
use them in your code.
The class is overkill in any case as there is no reason to hold the state.
--
To view, visit http://gerrit.ovirt.org/956
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
