Shahar Havivi has posted comments on this change. Change subject: added support for mirror promisc mode ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm/tc.py Line 23: class MirrorPromisc(): I don't agree that we need to wrap each call of tc, the superVdsm.setMirrorPromisc is doing a set of actions in order to set "mirror" mode, there is an inline mode as well that the qdisc_add will be different.... -- To view, visit http://gerrit.ovirt.org/956 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90f2f39c326528e76b10c68b1a101bd3ed7a20ec Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
