Dan Kenigsberg has posted comments on this change.
Change subject: Added blkid tool support in supervdsm.
......................................................................
Patch Set 4:
I simply fear that if there are tens (hundreds?) of partitions, we'd end up
executing blkid too many times.
p.s. the piece of code above could be made prettier with a helper function that
just reads /proc/partitions
def partitionDevices():
with open("/proc/partitions") as f:
f.next()
f.next()
for line in f:
yield line.split()[-1]
--
To view, visit http://gerrit.ovirt.org/2185
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
