Dan Kenigsberg has posted comments on this change. Change subject: Added blkid tool support in supervdsm. ......................................................................
Patch Set 4: Looks good to me, but someone else must approve Don't youmind the need to call getBlkId for each and every device? How many devices are expected to be using this function? maybe if you follow this patch with another one giving me a fuller picture, would make my understanding easier. -- To view, visit http://gerrit.ovirt.org/2185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
