Dan Kenigsberg has posted comments on this change.

Change subject: Added blkid tool support in supervdsm.
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File vdsm/blkid.py
Line 48:     blkIdDict = dict(map(lambda x: x.split('=', 1), out))
from what I read in the man page, the standard output has some quoting of funny 
chars, you just need to understand that encoding and decode it. Maybe I am 
wrong, but please take a look at the blkid code (or even try a disk label with 
spaces etc.

--
To view, visit http://gerrit.ovirt.org/2185
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9ad51df4f4b98e2aff5db1d9c02512045977a60
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to