Dan Kenigsberg has submitted this change and it was merged.
Change subject: ISCSI Subsystem refactoring
......................................................................
ISCSI Subsystem refactoring
!!Do not apply without following patch!!
Currently the iscsi subsystem is a mess of list concatenation.
This refactoring tries to:
- Make variable and object naming consistent and in line with iscsi
terminology.
Note that:
* portal now refers to an ISCSI Portal and not a tpgt
* ISCSI interfaces are modeled so that initiator name is
actually property of the interface and not its identity
- Make a coherent object hierarchy of the ISCSI objects. Functions
now expect to get ISCSI objects (like portal, target) instead of
scattered arguments that have to be validated and parsed every
time.
- Make the ISCSI interface a 1st class member. Up until now support
for multiple interfaces was amateurish at best.
- Support for different credentials for discovery and target. Ground
work to support authentication methods other then CHAP.
- Thin wrap around iscsiadm to separate cmdline parsing from actual
VDSM iscsi logic
Stuff known to be broken:
- implicit interface creation. As this was never officially
supported by VDSM I will not bring this back.
- tpgt is ignored. This is in line with old VDSM behaviour.
Note that the confusing naming is still used by the old API calls for
backward compatibility. New API calls should try and use correct naming
and format!
Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a
---
M vdsm.spec.in
M vdsm/constants.py.in
M vdsm/storage/Makefile.am
M vdsm/storage/hsm.py
M vdsm/storage/iscsi.py
A vdsm/storage/iscsiadm.py
M vdsm/storage/multipath.py
M vdsm/supervdsmServer.py
8 files changed, 595 insertions(+), 317 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1607
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b5f99598a559731951c271e97f04f03a2d2173a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: shu ming <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
