Bala.FA has posted comments on this change. Change subject: Added gluster tool support in supervdsm. ......................................................................
Patch Set 2: (3 inline comments) .................................................... File configure.ac Line 150: AC_PATH_PROG([GLUSTER_CLI_PATH], [gluster], [/usr/sbin/gluster]) Done .................................................... File vdsm/gluster_super.py Line 24: def execGluster(glusterArgList): If we think of putting each gluster call by call, then we will end up having gluster module inside vdsm itself. You can look into gluster_cli.py file in http://gerrit.ovirt.org/#change,2808. This file contains very basic gluster cli support now. If we start putting stuff what gluster cli provides into supervdsm, It will be a huge. I feel having execGluster is better than putting gluster stuff in. .................................................... File vdsm/Makefile.am Line 26: gluster_super.py \ Done -- To view, visit http://gerrit.ovirt.org/2797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
