Bala.FA has posted comments on this change. Change subject: Added gluster tool support in supervdsm. ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm/gluster_super.py Line 24: def execGluster(glusterArgList): I understand this in vdsm perspective. If we put individual gluster stuff, supervdsm will be bloated. Right now gluster cli requires root privilege for each and every command ie non-root is not permitted to run useful things. To make it work, we need to put gluster_cli.py stuff inside supervdsm if so. I think, not all gluster command requires root, but this will be fixed later sometime. I see there is no immediate plan for now. -- To view, visit http://gerrit.ovirt.org/2797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
