Bala.FA has posted comments on this change.
Change subject: Added gluster cli support in supervdsm.
......................................................................
Patch Set 3: (11 inline comments)
....................................................
File vdsm/gluster_cli.py
Line 63: tokens = line.split(":", 1)
Done
Line 82: volumeInfo["brickCount"] = tokens[1].strip()
brickCount is a string something like 'N x M = C'. However other keys eg.
replicaCount has intereger as string. Do you think its bad idea?!
Line 86: regex = re.compile('(\d+) x (\d+) = (\d+)')
Will fix that.
Line 445: hostName = ''
We are discussing internally what name we suppose to send. I will fix
according to that.
Line 451: uuid = ''
Done
Line 461: hostName = None
I will try to explain this in comments inside the code. I will do some changes
in the logic too.
Line 476: {HOSTNAME : {'uuid': UUID, 'hostName': HOSTNAME}, ...}
I go with uuid as key
....................................................
File vdsm/gluster_exception.py
Line 366: raise NameError("Collision found: code %s is used by %s
and %s" \
Done
....................................................
File vdsm.spec.in
Line 468: %{_datadir}/%{vdsm_name}/gluster_cli.py*
It can be in vdsm-gluster rpm. Do you say that vdsm has dependency to
vdsm-gluster?! otherwise, I guess, supervdsmServer.py will be broken.
....................................................
File vdsm/supervdsmServer.py
Line 31: from gluster_cli import volumeInfo as _glusterVolumeInfo
Done
Line 106: def glusterVolumeInfo(*args, **kwargs):
I will try this approach and fix it accordingly
--
To view, visit http://gerrit.ovirt.org/2797
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2faa261a3c44cf84af14102bdf6479287435793b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
