Igor Lvovsky has posted comments on this change.
Change subject: [WIP] Added blockSD.getImageMap().
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(11 inline comments)
not finished yet
....................................................
File vdsm/storage/blockSD.py
Line 60: BlockSDWalk = namedtuple("BlockSDWalk", "template, chain")
BlockSDWalk ??? what does it means?
Line 139: vols[lv.name] = BlockSDVol(lv.name, image, parent)
not very important, but why we need lv.name twice?
Line 148: def getImageMap(sdUUID):
what is it means getImageMap? Did you mean getDomainMap ?
Line 149: def getChain(leaf):
getChain ?? we already have it.
Line 157: metadata.
Sorry, but this explanation not so clear for me, but maybe it just me.
Line 163: p = vols[leaf.parent] #vols[p.parent]
please, remove dead code
Line 215: except KeyError:
you can't get KeyError here? if v.xxx doesn't exist you will get AttributeError
but in your case if v.parent or v.name don't exist you will get IncorrectFormat
from _makeBlockSDVols, right ?
Line 220: leafs = tuple(vol for vName, vol in vols.iteritems() if vName not
in parents)
Ah man, it's so complicated. Can you at least add some comments here?
....................................................
File vdsm/storage/fileSD.py
Line 245: Return dict {volUUID: imgUUID, parentUUID} of the domain.
is it new kind of dict ?
Line 251: volMetaPaths =
oop.getProcessPool(self.sdUUID).glob.glob(volMetaPattern)
why not self.oop.glob.glob(volMetaPattern) as in function above ?
Line 258: return volumes
where is a parent=None as you promised above?
--
To view, visit http://gerrit.ovirt.org/3462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eccf5ca100bd354aa09208ca60bb112fb697063
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
