Eduardo has posted comments on this change.
Change subject: [WIP] Added blockSD.getImageMap(), [block|file]SD.getAllVolumes
......................................................................
Patch Set 5: (6 inline comments)
....................................................
File vdsm/storage/blockSD.py
Line 139: break
No need for at this point. Different treatment is the result of the image
semantics.
Line 147: def getAllVolumes(sdUUID):
Add doc string:
Output dict
Template image is the 1st
Line 157: res[vName]['imgs'].insert(0, vImg)
There are images, no volumes.
An image can be based on a template image, and a template is raw.
Multiple images can be based on the same template.
The trick is we are putting the template self image at the list begin.
Line 159: not
vName.startswith(blockVolume.image.REMOVED_IMAGE_PREFIX) \
The image dependency is an artefact.
Until I resolve it want to avoid adding another dependency on this module.
Line 830: TODO: Remove and use getAllVolumes().
This function is superseded by getAllVolumes or a wrapper around it.
You got more info with less effort.
....................................................
File vdsm/storage/fileSD.py
Line 254: volumes[vName] = {'imgs': [], 'parent': None}
This 2 lines are from a bad rebase. Answer to the following comment.
--
To view, visit http://gerrit.ovirt.org/3462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eccf5ca100bd354aa09208ca60bb112fb697063
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
