Igor Lvovsky has posted comments on this change.
Change subject: vm payload: add file injection to vm
......................................................................
Patch Set 16: (2 inline comments)
I am sorry that it take so long time to review it
....................................................
File vdsm/clientIF.py
Line 205: 'vmPayload': ('file': {'filename': 'content'}}
Should it be '{' instead of '('.
what is 'file' here and why we need it? Can it be something else except the
'file'?
Line 212: drive['path'] =
supervdsm.getProxy().mkFloppyFs(files)
why this not consistent with rest function?
why you set drive['path'] here instead of volPath and return it?
--
To view, visit http://gerrit.ovirt.org/2321
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
