Dan Kenigsberg has posted comments on this change.

Change subject: vm payload: add file injection to vm
......................................................................


Patch Set 17: I would prefer that you didn't submit this

media location should include vmId (you do not want one Vm going down causing 
removal of second Vm media)

sysprep media is currently put at

 /var/run/vdsm/<vmId>.vfd

for vmpayload, i'd suggest to include either the <sha1hash> or simpler - the 
alias of the payload device, such as fda or sdb, to allow multiple payloads per 
vm in the future.

--
To view, visit http://gerrit.ovirt.org/2321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to