Shahar Havivi has posted comments on this change.

Change subject: vm payload: add file injection to vm
......................................................................


Patch Set 8: (6 inline comments)

....................................................
File vdsm/clientIF.py
Line 202:                  drive['specParams'].has_key('vmPayload'):
we are currently using that all over the code,
we will need to change it in all code at once.

....................................................
File vdsm/libvirtvm.py
Line 1978:                  drive['specParams'].has_key('vmPayload'):
same here 2...

....................................................
File vdsm/mkimage.py
Line 41:         '''
Done

Line 53: def _commonCleanFs(files, dirname, media):
Done

Line 82:         os.rmdir(dirname)
Done

....................................................
File vdsm/supervdsmServer.py
Line 196:     def removeFs(self, path):
Done

--
To view, visit http://gerrit.ovirt.org/2321
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to