Dan Kenigsberg has posted comments on this change. Change subject: Added Gluster file system management support. ......................................................................
Patch Set 11: I would prefer that you didn't submit this (4 inline comments) .................................................... File vdsm/gluster/api.py Line 34: wrapper.exportAsVerb = 'yes' I do not agree that the string 'yes' has any advantage over True. btw, you can do hasattr(func, 'exportAsVerb') and ignore the value of the attr outside the wrapper. Line 71: info["volumeStatus"] = "ONLINE" "ONLINE" is part of the API so better be defined as a "class enum". Line 83: 'INFINIBAND': 'rdma'} I don't quite follow why it's 'tcp' here and 'TCP' a funciton above. I'd prefer if the API was all enum (which happen to be strings), and that users are not to be allowed to play with the letter-case. In my opinion, the list->string conversion should be hidden as deep as possible - when passed to the command line. I should have noticed this long ago, but I would like to hear if you can fix this now or in a following patch. Line 99: if self.svdsmProxy.glusterVolumeStop(volumeName, force): not a blocker for this patch, but a point for thought: it may have been clearer and shorter if exportAsVerb had added this _SUCCESS to each verb return value. hmmm. is there anything that catches None in case of an error? We should never return None over xmlrpc. -- To view, visit http://gerrit.ovirt.org/2808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd51bec292991f7abdcacf3ba747c9662f660f51 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
