Bala.FA has posted comments on this change. Change subject: Added Gluster file system management support. ......................................................................
Patch Set 11: (5 inline comments) .................................................... File vdsm/gluster/api.py Line 34: wrapper.exportAsVerb = 'yes' Done Line 71: info["volumeStatus"] = "ONLINE" Done Line 83: 'INFINIBAND': 'rdma'} Are you saying transportList suppose to be a string? I suppose to pass comma separated string of transportList without any translation. The above transportMap is invalid. I will fix this. Line 99: if self.svdsmProxy.glusterVolumeStop(volumeName, force): Done Line 99: if self.svdsmProxy.glusterVolumeStop(volumeName, force): Most of gluster verbs here return success/failure, but few of them return success+more. Do you suggest to have another decorator for such verbs? In case of error, appropriate exception are raised by superVdsm. So there is no None returned. -- To view, visit http://gerrit.ovirt.org/2808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd51bec292991f7abdcacf3ba747c9662f660f51 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Eduardo <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
