Dan Kenigsberg has posted comments on this change.
Change subject: Added Gluster file system management support.
......................................................................
Patch Set 11: (2 inline comments)
....................................................
File vdsm/gluster/api.py
Line 83: 'INFINIBAND': 'rdma'}
the other way around: the api should be list of "enums". translation to/fro
comma separated string should be hidden deep in gluster_cli.
Line 99: if self.svdsmProxy.glusterVolumeStop(volumeName, force):
I'm suggesting that volumeSetOptionsList() returns {'volumeSetOptions':
self.svdsmProxy.glusterVolumeSetHelpXml()}
@exportAsVerb can add _SUCCESS to that.
But my main issue is that you should not call "if" on a function that never
return False. It is misleading.
--
To view, visit http://gerrit.ovirt.org/2808
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd51bec292991f7abdcacf3ba747c9662f660f51
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
